Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14201
In the past these defaults would be set on the schema, however now that they can't be we have to check if they're set and, if not, set them to the defaults manually.
We have 2 functions
MultiEnvSearch
which assumes its a string andMultiEnvDefault
which returns an interface and allows a default value to be set in the case the env var isn't set.All of these were using
MultiEnvSearch
- most are strings exceptUSER_PROJECT_OVERRIDE
- in this case we need it to be a bool.On top of that we were checking
d.Get() == ""
, but in this cased.Get
wasfalse
so we have to checkd.GetOk
, from here we need to make it a bool rather than a string, so added in the ParseBool.I checked the rest of these defaults that moved from the schema to here and they indeed are all strings, so I put the logic on this individual case rather than in the
MultiEnvDefault
functionIf this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#7644