Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cluster location a required field #14330

Conversation

modular-magician
Copy link
Collaborator

Cluster location is marked as optional. It should be marked as required because we might extend the regional API to zonal and therefore can't use the provider default region/environment variable for region.

Solutions considered:

  1. Inherit the provider location/region
    • It doesn't work right now because it is not added in ProviderConfig
    • It is undesirable as it restricts us from extending the API from regional to zonal.
  2. Get the location from environment variables
    • Same issue as non-extensibility.
  3. Mark Location as a required field
    • Ensures extensibility of the APIs in future.

Solution accepted: Mark location as a required field.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

alloydb: changed `location` from `optional` to `required` for `google_alloydb_cluster`. `location` had previously been marked as optional, but operations failed if it was omitted, and there was no way for `location` to be inherited from the provider configuration or from an environment variable. This means there was no way to have a working configuration without `location` specified.
alloydb: changed `location` from `optional` to `required` for `google_alloydb_cluster`. `location` had previously been marked as optional, but operations failed if it was omitted, and there was no way for `location` to be inherited from the provider configuration or from an environment variable. This means there was no way to have a working configuration without `location` specified.

Derived from GoogleCloudPlatform/magic-modules#7652

* Make cluster location a required field

* Corrected Go formatting

* Add comment to test

* Rename testAccPreCheck to AccTestPreCheck

* Mark weeklySchedule as `optional`

* Add Test for marking weeklySchedule as `optional`

* Revert "Mark weeklySchedule as `optional`"

This reverts commit 5349460713b407794adfd959cdf78a698ad2ad73.

* Revert "Add Test for marking weeklySchedule as `optional`"

This reverts commit 04f2d47ef4f5a2c46b7a03050cdc68a9a42c5c41.

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 4a1460e into hashicorp:main Apr 15, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant