Add google_datastream_static_ips data source #14487
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
google_datastream_static_ips
data source, enabling automated access to the Datastream IP allowlists via the projects.locations.fetchStaticIps API method.This is similar to the
google_monitoring_uptime_check_ips
data source (#3320), except that the API method requires aname
parameter passing to it, which is constructed fromproject
andlocation
(projects/{project}/locations/{location}
).The data source therefore accepts
project
andlocation
as inputs.project
is optional, as that can be inferred from the provider configuration.location
is required however as, whilst it could be inferred throughgetLocation
, it's not appropriate to infer it because:getLocation
can fall back to a zone argument, whereas the fetchStaticIps method only supports regions.{{location}}
intoReplaceVars
doesn't invoke the fallback behaviour fromgetLocation
, so even if it was useful & appropriate to use it would actually just construct an invalid name ofproject/my-project/:fetchStaticIps
Fixes #12928
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#7847