Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server tls policy #14557

Merged
merged 1 commit into from
May 10, 2023
Merged

Server tls policy #14557

merged 1 commit into from
May 10, 2023

Conversation

modular-magician
Copy link
Collaborator

Add configuration for traffic director serverTlsPolicy resource

part of #14040

If this PR is for Terraform, I acknowledge that I have:

  • [ x] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [ x] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [ x] Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • [ x] Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [ x] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_network_security_server_tls_policy`

Derived from GoogleCloudPlatform/magic-modules#7822

@modular-magician @slevenick @SarahFrench
Server tls policy (hashicorp#7822)
5760c35 
* Configuration for traffic director Mesh resource.

* Add more tests for Mesh resource

* Use new provider for test

* Configuration for service binding.

* Add hand written test for service binding.

* Revert "Add hand written test for service binding."

This reverts commit 367449af370e7e09509cba20d24ed2c152251072.

* Update service binding yaml.

* reduce timeouts.

* Update mmv1/products/networkservices/ServiceBinding.yaml

Co-authored-by: Sam Levenick <slevenick@google.com>

* Service binding update test.

* Fix compile error.

* Mark the Service Binding resource immutable.

* Add configuration for server tls policy.

* Remove extra files.

* Add tests.

* Revert "Remove extra files."

This reverts commit 0791d448f775b7c9c705ad4f6ff35d45b05b114c.

* Update mmv1/third_party/terraform/tests/resource_network_security_server_tls_policy_test.go.erb

Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>

* Address PR comments.

* Server Tls Policy

* Address PR comments.

* Address PR comments.

---------

Co-authored-by: Madhura Phadnis <madhurap@google.com>
Co-authored-by: Sam Levenick <slevenick@google.com>
Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit b7c3699 into hashicorp:main May 10, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@modular-magician