Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cloud Run v1 Multi-Container Example with New Fields #14647

Conversation

modular-magician
Copy link
Collaborator

Adds support for the container name and empty dir volume fields in Cloud Run v1 Services and adds a multi-container example using these fields.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudrun: Added field `template.spec.containers.name` to `google_cloud_run_service`
cloudrun: Added beta field `template.spec.columes.empty_dir` to `google_cloud_run_service`

Derived from GoogleCloudPlatform/magic-modules#7971

)

* cloudrun: Add container name field for Services

Adds the template.spec.containers.name field for specifying container
names in Cloud Run v1 Services.

* cloudrun: Update the description of the Service containers field

Updates the description of the Cloud Run v1 Service field
template.spec.containers to reflect that the field is repeated and to
remove other obsolete information.

* cloudrun: Add empty dir volume type for Services

Adds the beta template.spec.volumes.empty_dir field for configuring
ephemeral volumes in Cloud Run v1 Services.

* cloudrun: Add multi-container Service example

Adds an example google_cloud_run_service resource with multiple
containers and a shared empty dir volume. Container dependencies are
specified as a json encoded annotation.

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit e8f711c into hashicorp:main May 18, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant