Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make google_notebooks_instance metadata field updatable #14650

Merged
merged 1 commit into from
May 18, 2023
Merged

Make google_notebooks_instance metadata field updatable #14650

merged 1 commit into from
May 18, 2023

Conversation

modular-magician
Copy link
Collaborator

Fixes #14403.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

notebooks: added update-in-place support for `google_notebooks_instance.metadata` field

Derived from GoogleCloudPlatform/magic-modules#7945

@modular-magician
Make google_notebooks_instance metadata field updatable (hashicorp#7945)
1858f7e 
* Added update tests proving that metadata is not updatable

* Test fixes

* Made notebooks instance metadata field updatable

* Added metadata to ImportStateVerifyIgnore for impacted tests

* Removed non-updatable fields from update test

* Temporarily made metadata field not updatable to prove that only these changes are required to make the tests pass

* Revert "Temporarily made metadata field not updatable to prove that only these changes are required to make the tests pass"

This reverts commit f22a9e4cd29c3e0d35c1888aca5280a1bef6c22b.

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit d1fae80 into hashicorp:main May 18, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for updating google_notebooks_instance.metadata
1 participant
@modular-magician