Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement resource google_compute_network_endpoints #14869

Conversation

modular-magician
Copy link
Collaborator

Implements google_compute_network_endpoints to define multiple endpoints for a zonal NEG in a single resource. The main benefit over google_compute_network_endpoint is that this resource batches calls to attachNetworkEndpoints (and detachNetworkEndpoints), which should drastically speed up attachment/detachment if you have a lot of endpoints. See #14730 for more details.

Initial implementation only allows one of these per NEG, which is probably fine? Separate google_compute_network_endpoint resources should be fine alongside this if needed.

File naming can be changed, it currently mirrors those of google_compute_network_endpoint.

part of #14730

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_compute_network_endpoints`

Derived from GoogleCloudPlatform/magic-modules#8068

* implement resource google_compute_network_endpoints

* enforce max size on network endpoints

* fix NetworkEndpoints.yaml whitespace

* remove custom importer and change from set to unordered list

* specify in the documentation that NetworkEndpoints is authoritative

* change back to set from unordered_list

* fix typo in pre_delete

* implement pagination to support mutability

* change endpoints -> network_endpoints and fix test checks

* change mutate timeout to create/delete depending on action

* fix assignment typo

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 86324da into hashicorp:main Jun 9, 2023
4 checks passed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant