Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support project numbers in monitored project #15305

Conversation

modular-magician
Copy link
Collaborator

fixes #15211

  • needed a diff suppress for short & long versions with project name and number
  • modified the decoder to look for a project number instead of project id when given a project number
  • added two acceptance tests for short and long form project number creation
  • added unit tests for diff suppress function

Completed the following manual upgrade tests:

  • created w/ long id in 4.70 -> upgraded to built provider successfully

  • created w/ short id in 4.70 -> upgraded to built provider successfully

  • created w/ long num in 4.70 -> upgraded to built provider successfully

  • created w/ short num in 4.70 -> upgraded to built provider successfully

  • created w/ long id in 4.75 -> upgraded to built provider successfully

  • created w/ short id in 4.75 -> upgraded to built provider successfully

  • created w/ long num in 4.75 & failed as expected, could not upgrade without importing

  • created w/ short num in 4.75 & failed as expected, could not upgrade without importing

Release Note Template for Downstream PRs (will be copied)

monitoring: fixed an issue in `google_monitoring_monitored_project` where project numbers were not accepted for `name`

Derived from GoogleCloudPlatform/magic-modules#8454

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 1f39080 into hashicorp:main Jul 26, 2023
4 checks passed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-creation of existing google_monitoring_monitored_project resource for project number name
1 participant