TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions #15613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…builds vs ad hoc builds, add project descriptions (hashicorp#8685) * Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date. * Add ability to set project descriptions using a context parameter * Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter * Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful * Update tag for nightly test builds to be static/consistent Signed-off-by: Modular Magician <magic-modules@google.com>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
modular-magician
deleted the
downstream-pr-72d9661eebf46d2c74961dae3f1d06daf2f6d634
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address two areas where users of the new project might be confused:
To address these problems I'm going to add descriptions to projects in TeamCity, and also add a step to build configurations so they automatically tag themselves based on how they're triggered.
Builds triggered by the cron schedule at night will be labelled
nightly-YYYY-MM-DDnightly-test,with the date in the tag. All other builds are tagged withone-off-build. Builds know if they're triggered by cron or not based on whether there's details about a user who triggered a given build (directly or indirectly, via dependencies)Here's a test project where I set this up - if you trigger a build it'll be tagged appropriately. Note: this project has none of the ENVs set up, so all the builds will fail their tests but they'll be able to do the tagging fine.
If this PR is for Terraform, I acknowledge that I have:
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#8685