Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully supporting Dialogflow CX Page and Flow objects #15668

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Fully supporting Dialogflow CX Page and Flow objects #15668

merged 1 commit into from
Aug 29, 2023

Conversation

modular-magician
Copy link
Collaborator

This fills out a bunch of stuff that was missing including:

I have deliberately skipped the following:

  • EndInteraction because it's "generated by Dialogflow only and not supposed to be defined by the user"
  • MixedAudio also because it's "generated by Dialogflow only and not supposed to be defined by the user"
  • KnowledgeInfoCard because it contains no fields and I didn't know how to do that
  • ResponseType because, AFAICT, it's not an input.

I might have accidentally missed some things too.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

dialogflowcx: added `response_type`, `channel`, `payload`, `conversation_success`, `output_audio_text`, `live_agent_handoff`, `play_audo`, `telephony_transfer_call`, `set_parameter_actions`, and `conditional_cases` fields to `google_dialogflow_cx_flow` resource

dialogflowcx: added `response_type`, `channel`, `payload`, `conversation_success`, `output_audio_text`, `live_agent_handoff`, `play_audo`, `telephony_transfer_call`, `reprompt_event_handlers`, `set_parameter_actions`, and `conditional_cases` fields to `google_dialogflow_cx_page` resource

Derived from GoogleCloudPlatform/magic-modules#8757

@modular-magician
Fully supporting Dialogflow CX Page and Flow objects (hashicorp#8757)
9056d58 
* Fully supporting Dialogflow CX Page and Flow objects

This fills out a bunch of stuff that was missing including:
- repromptEventHandlers (hashicorp#14573)
- setParameterActions (hashicorp#14572)
- payload, and other fulfillment messages (hashicorp#12946)

* Allowing JSON values to actually be values (instead of just objects)

* Adding "basic" Flow creation, filling out "full" Flow creation with (I hope) all params

* Oops, missed Flow messages.response_type example

* Adding "basic" Page creation, filling out "full" Page creation with (I hope) all params

* Oops, missed response_type and had an extra level of nested messages{} somehow

* Adding return_partial_response + webhook (?!)

* Fixing conditionalCases: it's now a JSON encoded list, instead of a list of JSON encoded objects

* Normalizing whitespace in examples + tests; it's now all spaces (I hope)

* Fixing examples / tests

* Normalizing whitespace in basic examples

* Fixing examples: empty conditions are supposed to be null / missing

* Fixing examples: tag should only be set when webhook is set (we'll see if I need to set webhook everywhere)

* Fixing code: responseType is ignored when creating/updating resources

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 665e344 into hashicorp:main Aug 29, 2023
4 checks passed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@modular-magician