Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [dns] fix hash function for network_url in ManagedZone and Policy resources #15728

Conversation

modular-magician
Copy link
Collaborator

When someone is trying to attach a private DNS zone to multiple networks in different projects, if the network name is the same across some of those projects, the resource will only attach only one of that networks with the same name, even if they are on different projects.

Example:

  • Project project1 with networks network1 and network2 to be attached
  • Project project2 with networks network2 and network3 to be attached

The Terraform resource will only try to attach network1 from project1, network2 and network3 from project3 thus ignoring network2 from project1

Updating the way how the resource is handling the hash will fix this issue.

resource "google_dns_managed_zone" "x" {
  dns_name      = "dummy.com."
  force_destroy = true
  name          = "dummy.com"
  project       = "dummy-project"
  visibility    = "private"

  cloud_logging_config {
    enable_logging = false
  }

  private_visibility_config {
    networks {
      network_url = "https://www.googleapis.com/compute/v1/projects/project1/global/networks/network1"
    }
    networks {
      network_url = "https://www.googleapis.com/compute/v1/projects/project1/global/networks/network2"
    }
    networks {
      network_url = "https://www.googleapis.com/compute/v1/projects/project2/global/networks/network2"
    }
    networks {
      network_url = "https://www.googleapis.com/compute/v1/projects/project2/global/networks/network3"
    }
  }
}

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

dns: fix hash function for network_url in ManagedZone and Policy resources

Derived from GoogleCloudPlatform/magic-modules#8716

…y resources (hashicorp#8716)

* fix: [dns] fix hash function for network_url in ManagedZone and Policy resources

* add tests for multiproject with same network names

* Update mmv1/products/dns/ManagedZone.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Update mmv1/products/dns/Policy.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* add project creation

* Update mmv1/products/dns/ManagedZone.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Update mmv1/products/dns/Policy.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Update dns_managed_zone_private_multiproject.tf.erb

* add missing project services

* fix project references

* add depends_on

* improve tests

* fix special characters

* fix billing_account

* add depends_on on project_service

* fixed dependencies

* fix depends_on

* remove var of dns_name and add depends_on

* fix deterministic order

---------

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit c3817ef into hashicorp:main Sep 5, 2023
4 checks passed
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant