Use Create instead of Patch to create google_service_networking_connection #15761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction (hashicorp#8872) * Use Create instead of Patch to create google_service_networking_connection * Remove bootstraped networks for service networking connection * Use resource google_compute_network for tests * Fix tests Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
merged commit 4094846
into
hashicorp:FEATURE-BRANCH-major-release-5.0.0
3 checks passed
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10830
The bootstrapped network cannot be used, as an error is returned
Hope it will not affect the nightly tests so much.
The note is added to 5.0 guide in PR GoogleCloudPlatform/magic-modules#8889
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#8872