Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal IPV6 support for GoogleComputeAddress and ComputeInstance resources #15780

Conversation

modular-magician
Copy link
Collaborator

This PR includes:

  • new field ipVersion for resource google_compute_address for reserving private ipv6 addresses (possible values IPV4 and IPV6)
  • new acceptance test for ipv6 on google_compute_address resource
  • new field ipv6Address in networkInterface for google_compute_instance resource to assign static ipv6 prefix address (new field support both ip address and reference to existing google_compute_address ipv6 resource).
  • update to ipv6 address, although being implemented, seems not to work due to issue in the patch API for network interface (tested with API and got same behaviour), I will open a ticket on the API to check for that

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added `ipVersion` field to `google_compute_address` resource
compute: added `ipv6Address` field to `google_compute_instance` resource

Derived from GoogleCloudPlatform/magic-modules#8432

…e resources (hashicorp#8432)

* Address added ipVersion parameter for reserving both ipv4 and ipv6 addresses
Instance added ipv6Address for assigning static ipv6 address to compute instance resource
ComputeInstance added test for internal ipv6 new field

* Fix yaml syntax issues

* Fixes

* Add ipv6PrefixLength and fix tests

* added ipv6PrefixLength and ipv6Address to compute_instance_template

* added ipv6PrefixLength and ipv6Address to region_compute_instance_template

---------

Co-authored-by: Luca Prete <lucaprete@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 321a31e into hashicorp:main Sep 8, 2023
4 checks passed
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant