feat: add the new resource: google_dataflow_pipeline
#15785
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #12608
To merge this PR I have at least 3 problems.
I do not have a deep understanding of
magic-modules
and its associated systems, so I am looking for help from Reviewers.Originally, it would be very smart if the resource name could be
google_dataflow_pipeline
as in the original issue. However,dataflow_job
already exists on the third_party side, and I could not use dataflow in yaml.Specifically, if I created a
dataflow
directory and created a Pipeline Object in it,make vet
failed after outputting the provider.I was able to pass unittest locally as shown in the checkbox. However, I do not currently have the appropriate GCP project for verification and have not been able to verify that this provider works as we think it should. I would appreciate any good solutions if possible. I will continue to investigate this issue and may be able to implement it if a suitable IAM is found in a our GCP project. Or I may look into creating my own dedicated project.
This PR just rewrites GCP's complex parameters directly into terraform. I don't consider myself particularly good at using a lot of NestedObjects; I did it this way because I didn't know how to implement yaml. If you have a good solution, please let me know.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#7325