Fix id validation for custom service and SLO to match what's actually usable #15841
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15825
The validation for the following id fields were too strict, so they have been adjusted to match the actual formats. Please refer to the issue for specific examples.
service_id
ongoogle_monitoring_custom_service
slo_id
ongoogle_monitoring_slo
I checked this documentation. Types of breaking changes | Magic Modules
This change relaxes the validation to contain the current pattern, so I think this is not a breaking change.
Do I need to add tests for the validation defined in regex? If so, I'll add it.
It would be helpful if you could advise on existing test cases for such a change.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#8939