Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make plugin-framework provider configuration code treat empty values like the SDK #15844

Commits on Sep 14, 2023

  1. Make plugin-framework provider configuration code treat empty values …

    …like the SDK (hashicorp#8798)
    
    * Make PF config code change `project = ""` to null value before checking ENVs
    
    * Make plugin framework config code change all empty strings in config to null values
    
    * Fix defect in unit test for `project`, uncomment
    
    * Uncomment empty string unit tests
    
    * Fix defect in test; expeceted value should be null list
    
    * Add handling of empty lists in `HandleZeroValues`
    
    * Fix typo in comment
    
    * Add test case asserting `impersonate_service_account` empty strings are overridden by an ENV
    
    * Update SDK `batching` tests: rename test cases,  make it clear values are arbitary
    
    * Update `HandleZeroValues` to handle `batching` argument
    
    * Uncomment empty string test
    
    * Change test inputs from 123s to 45s
    
    This is because 123s is transformed to 2m3s, but 45s remains 45s
    
    * Protect against Batching being null/unknown in `HandleZeroValues`
    
    * Add non-VCR acceptance test that shows provider behaviour when `credentials=""` and `GOOGLE_CREDENTIALS` interact
    
    Signed-off-by: Modular Magician <magic-modules@google.com>
    modular-magician committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    5ce0565 View commit details
    Browse the repository at this point in the history