Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecretManager Secret: Prevent recreation for "automatic" to "auto" #15922

Conversation

modular-magician
Copy link
Collaborator

fixes #15885

Creates a custom diff that prevents immutability when following upgrade guide steps for replication.auto
Things to note:

  • Does not prevent the reverse: removing "auto" and adding "automatic"
  • Updating to an empty auto {} still calls the API with a trivial PATCH request.

Tested manually with local provider.

Release Note Template for Downstream PRs (will be copied)

secretmanager: fixed an issue in `google_secretmanager_secret` where replacing `replication.automatic` with `replication.auto` would destroy and recreate the resource

Derived from GoogleCloudPlatform/magic-modules#9030

…ashicorp#9030)

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit a14452b into hashicorp:main Sep 20, 2023
4 checks passed
trodge pushed a commit that referenced this pull request Sep 21, 2023
…9030) (#15922)

Signed-off-by: Modular Magician <magic-modules@google.com>
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant