Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change: Rework taint model in GKE #15959

Conversation

modular-magician
Copy link
Collaborator

Part of #7928, #13309

This applies roughly the same model we're using with labels, where we limit what we write back into state during reads based on what's already in state. This gives us the opportunity to drastically simplify the interactions of the field, while unfortunately trading away authoritative-ness. We could easily reintroduce an authoritative field by making effective_taints O+C though- one of the benefits of effective_X output fields here and in the labels rework.

Not having update support is awkward- we'd be able to pick up new keys to manage if so, and delete keys, but that'll only update google_container_node_pool when added due to other complications with GKE cluster.

TestAccContainerNodePool_withSandboxConfig gets drastically simpler with this change- it's boring now! There's an unmanaged taint being added in the background there, with the withNodeConfig tests already covering taints added at create time.

Release Note Template for Downstream PRs (will be copied)

container: reworked the `taint` field in `google_container_cluster` and `google_container_node_pool` to only manage a subset of taint keys based on those already in state. Most existing resources are unaffected, unless they use `sandbox_config`- see upgrade guide for details.
container: added the `effective_taints` attribute to `google_container_cluster` and `google_container_node_pool`, outputting all known taint values

Derived from GoogleCloudPlatform/magic-modules#9011

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 478374a into hashicorp:FEATURE-BRANCH-major-release-5.0.0 Sep 22, 2023
3 checks passed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant