DNS: always set rrdatas and routing_policy when reading record_set #16042
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivating bug: b/301469376
Currently on read, we only update
rrdatas
orrouting_policy
if there is a non-nil value to be read from the API response - ifrrdatas
orrouting_policy
is nil, we don't do anything. This is a problem specifically when out-of-band changes are made, since either field could be set to nil and we would never update the state to match (e.g. ifrrdatas
is switched torouting_policy
outside of Terraform, we would not updaterrdatas
to nil within the Terraform state).Setting
rrdatas
androuting_policy
unconditionally on read (withflatten
when appropriate) should resolve this.Derived from GoogleCloudPlatform/magic-modules#9092