Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Oracle support to DBMS #16087

Conversation

modular-magician
Copy link
Collaborator

Fixes #15647

Adds support for Oracle profiles in DBMS, additionally adds missing static/private connectivity support to postgres profiles (that was also included with the Oracle profiles).

Two quirks happening here:
We can not actually create an oracle DB for testing (so the created tests fail, as it actually tests a connection to the supplied db)
The data stream private connection is actually a more generic resource than just data stream (reaches the same downstream URI with the same structure), so it would work for that oracle test... in theory

Release Note Template for Downstream PRs (will be copied)

databasemigrationservice: added support for `oracle` profiles to `google_database_migration_service_connection_profile`

Derived from GoogleCloudPlatform/magic-modules#9114

[upstream:e42af6b9a19a00d387c3dbbb340bd33630cd94a3]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 17fe118 into hashicorp:main Oct 3, 2023
4 checks passed
Copy link

github-actions bot commented Nov 2, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for oracle to google_database_migration_service_connection_profile
1 participant