Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send update request if updatemask is empty for resources with terraform_labels field #16111

Conversation

modular-magician
Copy link
Collaborator

Fixes #16091

If the updateMask is empty, it means that no update is needed. The update request is not needed to be sent.

Release Note Template for Downstream PRs (will be copied)

provider: fixed the bug that update request is sent to services when updateMask is empty

Derived from GoogleCloudPlatform/magic-modules#9154

…erraform_labels field (hashicorp#9154)

* Don't send update request if updatmask is empty when resource has terraform_labels

* Remove the function check field_specific_update_methods

* Set project to billing project for google_network_security_address_group

* Change back of project for resource google_network_security_address_group
[upstream:c6531043f144daec5952b4af2ccf0ace9d3959b4]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit b7cea94 into hashicorp:main Oct 4, 2023
4 checks passed
@kevinjom
Copy link

kevinjom commented Oct 5, 2023

hi, when will the fix be released?

Copy link

github-actions bot commented Nov 5, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error updating {{resource}}: The update_mask in the Update{{resource}}Request must be set
2 participants