Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix an issue in InternalIpDiffSuppress #16115

Conversation

modular-magician
Copy link
Collaborator

Fixes #15916

Release Note Template for Downstream PRs (will be copied)

compute: fixed a false permadiff on `ip_address` when it is set to ipv6 on `google_compute_forwarding_rule`

Derived from GoogleCloudPlatform/magic-modules#9062

* fix an issue in InternalIpDiffSuppress

* added tests

* update a function

---------

Co-authored-by: Edward Sun <sunedward@google.com>
[upstream:bf3557dd1720a2366b9fef23625a9693e3c08902]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 0c5724f into hashicorp:main Oct 4, 2023
4 checks passed
Copy link

github-actions bot commented Nov 4, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting ip_address to IPv6 for google_compute_forwarding_rule causes recreation
1 participant