Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataform Repository Resource Adding requested fields #16205

Conversation

modular-magician
Copy link
Collaborator

Dataform Repository Resource Adding Service Account and SshAuthentication fields, this was requested to our team through internal mail chain from a client.

Product Resource API Documentation: https://cloud.google.com/dataform/reference/rest/v1beta1/projects.locations.repositories

Did Manual Testing and it creates the repository successfully with the added fields.

Release Note Template for Downstream PRs (will be copied)

dataform: added `ssh_authentication_config` and `service_account` to `google_dataform_repository` resource

Derived from GoogleCloudPlatform/magic-modules#9202

* Dataform Repository Resource Adding Service Account and SshAuthenticationConfig

* Adding separate test exmple file and enhancing descriptions for repository resource

* Adding example in repository resource

* Fixing test for Dataform Repository resource
[upstream:95fe4c502e9f9aba11f71ec9c17ce1998cedbac8]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit f1d6333 into hashicorp:main Oct 10, 2023
4 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant