Making google_dialogflow_cx_version update work #16214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Making google_dialogflow_cx_version update work I also took the opportunity to turn the Version and Environment resources into mmv1 resources instead of handwritten ones. It needed only a small update to the dialogflow async operations code. * Oops, was updating an immutable field * Skipping documentation generation for "regional" tests It's confusing and not useful, given that the "regional" tests were specifically to exercise a bug. * Reverting possibly breaking cleanup * Preserving CustomizeDiff behavior * PR feedback: switching location to us-central1 for tests + making issue name more parseable [upstream:33c1fb4639fbad7163fd43820605d89f7858b699] Signed-off-by: Modular Magician <magic-modules@google.com>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making google_dialogflow_cx_version update work. I also took the opportunity to turn the Version and Environment resources into mmv1 resources instead of handwritten ones. It needed only a small update to the dialogflow async operations code.
Fixes #16131
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9177