Fix permadiff when edition field is added to configuration of a google_sql_database_instance resource
#16215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogle_sql_database_instance` resource (hashicorp#9198) * Suppress diff on `google_sql_database_instance`'s `edition` field when state contains `""` and config contains `"ENTERPRISE"` * Remove `DiffSuppressFunc`, add flattener and expander to handle conversion of `""` to `"ENTERPRISE"` * Remove duplicate import * Set default value of `edition` to `"ENTERPRISE"` * Remove expander, add state upgrader * Add acceptance test step that provisions an instance without `edition` set * Update tests to assert the value in state matches the edition used, including when edition is not set in config * Remove state upgrader [upstream:241a15cb0ed6ae99c3290825051f168deda648fd] Signed-off-by: Modular Magician <magic-modules@google.com>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15553
This PR adds a diff suppress that helps the provider handle a problem with the Cloud SQL API. If you create a database instance without specifying an edition it will default to ENTERPRISE. However the edition field is not returned in GET requests to the API. If you create the resource and specify the edition in the initial create action then the edition field is returned as part of the API response. As a result
""and"ENTERPRISE"are equivalent values ofeditionfor agoogle_sql_database_instanceresource.See #15553 (comment) for more info.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9198