fix issue #14893: add the customWriterIdentity parameter to logging_s… #16216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…logging_s… (hashicorp#8995) * fix issue hashicorp#14893: add the customWriterIdentity parameter to logging_sink resources Signed-off-by: Gang Chen <gangcchen@google.com> * ignore the customer_writer_identity field in test case Signed-off-by: gangchen03 <gangcchen@google.com> * Format the modified code and refactor the log client creation statement Signed-off-by: gangchen03 <gangcchen@google.com> * update project sink creation request object with proper variable name Co-authored-by: Riley Karson <rileykarson@google.com> * Update the sink resource documentation and remove the WriterIdentity field in update input Signed-off-by: Gang Chen <gangcchen@google.com> * refactor logging project sink to have consistent request format between create and patch Signed-off-by: Gang Chen <gangcchen@google.com> * Allow the test case to patch the customer_writer_identity field Signed-off-by: Gang Chen <gangcchen@google.com> * Fix code comment typo based on code review Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Add testCheckFuncs to validate the custom_writer_identity returned as Writer_identity output Signed-off-by: Gang Chen <gangcchen@google.com> * gofmt the test case Signed-off-by: Gang Chen <gangcchen@google.com> * Fix writer_identity TestCheckFunc in create test case Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Fix writer_identity TestCheckFunc in update test case Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Add headers for all Examples in logging sink document page Signed-off-by: Gang Chen <gangcchen@google.com> * Update custom_writer_identity field description in project sink documentation Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Remove uniqueWriterIdentity dependency for customerWriterIdentity in project logging sink documentation Signed-off-by: Gang Chen <gangcchen@google.com> --------- Signed-off-by: Gang Chen <gangcchen@google.com> Signed-off-by: gangchen03 <gangcchen@google.com> Co-authored-by: Riley Karson <rileykarson@google.com> Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> [upstream:cd543bb71eb3c5e146678d93042aaa9580486569] Signed-off-by: Modular Magician <magic-modules@google.com>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ink resources
Fixes #14893
add the customWriterIdentity parameter to logging_sink.
This PR only fixes the project logsink.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#8995