Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update bigquery transfer config #16269

Conversation

modular-magician
Copy link
Collaborator

Dynamically add update mask for changed properties instead of having a static list of all updatable properties.

In the case of service_account_name, it is only added to the update mask if it was set to a non-null value, as service_account_name cannot be removed from a transfer config using the patch API.

Fixes #16033 and #16126

Release Note Template for Downstream PRs (will be copied)

bigquerydatatransfer: fixed an error when updating `google_bigquery_data_transfer_config` related to incorrect update masks

Derived from GoogleCloudPlatform/magic-modules#9212

[upstream:ba4e63a4266cd105f28fc58575fd69c165fab747]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit abe8bca into hashicorp:main Oct 17, 2023
4 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccBigqueryDataTransferConfig
1 participant