Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle bigquery_reservation_capacity_commitment creation when capacity_commitment_id is unspecified #16320

Conversation

modular-magician
Copy link
Collaborator

Fixes #16204.

Release Note Template for Downstream PRs (will be copied)

bigqueryreservation: fixed bug of incorrect resource recreation when `capacity_commitment_id` is unspecified in resource `bigquery_reservation_capacity_commitment`

Derived from GoogleCloudPlatform/magic-modules#9293

…y_commitment_id is unspecified (hashicorp#9293)

* handle bigquery_reservation_capacity_commitment creation when capacity_commitment_id is unspecified

* revert change to import_format

* fix indentation

* add custom import

* add custom import file
[upstream:d4cafef987e2817b2c047be7d995535cadd9485b]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit a3205a9 into hashicorp:main Oct 20, 2023
2 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_bigquery_capacity_commitment should probably make capacity_commitment_id as required
1 participant