Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add provider attribute universe_domain #16323

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Add provider attribute universe_domain #16323

merged 1 commit into from
Oct 20, 2023

Conversation

modular-magician
Copy link
Collaborator

Add provider attribute universe_domain

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

provider: added `universe_domain` attribute as a provider attribute

Derived from GoogleCloudPlatform/magic-modules#8657

@modular-magician
Add provider attribute universe_domain (hashicorp#8657)
c7777db 
* Add provider attribute universe_domain

* Replace universe domain field with env vars, added more tests for storage and pubsub

* Extract universe domain from SA key file

* Include JWT scoped flow for authentication

* Add JWT Scoped flow in default application credentials

* Add test for GDU, enhance logging

* Resolve build issue

* Create package for tests, resolve review discussions

* Modify logic to copy test files to down-streams

* Change test package name from universe_test to universe

* Update indentation on framework_config.go.erb

* Update indentation on framework_config.go.erb

* Update credential logging message

Co-authored-by: Riley Karson <rileykarson@google.com>

* Remove universe_domain replacement in utils.go for long URL replacement

* Update error message for conflicted universe_domain definition

* Add basic description for universe_domain.

* Modify error message when universe domain mismatches

---------

Co-authored-by: Riley Karson <rileykarson@google.com>
[upstream:340c76db3af4002dc19dafce9f160ba75b5aef72]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit ebb32bb into hashicorp:main Oct 20, 2023
4 checks passed
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@modular-magician