Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backfill terraform_labels with state upgrader for the immutable MMv1 resources #16518

Conversation

modular-magician
Copy link
Collaborator

fixes #16424

Backfill terraform_labels with state upgrader for the immutable MMv1 resources

  • Beyondcorp_app_gateway
  • Certificate_manager_certificate_issuance_config
  • Datastream_private_connection
  • Ml_engine_model
  • Network_services_service_binding (beta)
  • Bigquery_job
  • Cloud_run_domain_mapping

Two immutable resources are not impacted and not state upgrader is added for them.

  • Network_connectivity_policy_based_route (added in 5.4)
  • Database_migration_servcie_private_connection (added in 5.1)

Release Note Template for Downstream PRs (will be copied)

provider: backfilled `terraform_labels` for some immutable resources, so resource recreation won't happen during provider upgrade from 4.X to 5.7

Derived from GoogleCloudPlatform/magic-modules#9438

…resources (hashicorp#9438)

[upstream:61ca630b03604b8cab95d14849022aebf88971e5]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit e613a66 into hashicorp:main Nov 13, 2023
4 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant