Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Adding Unexpected Conditions #16683

Conversation

modular-magician
Copy link
Collaborator

Fixes #14044

storage: fixed unexpected `lifecycle_rule` conditions being added for `google_storage_bucket`

Derived from GoogleCloudPlatform/magic-modules#9547

* Fix Adding Unexpected Conditions

* Adds no_age field

* Modify no_age description and variables name.

Adds relevant comments.

* Fixes Build Failure

* Fixes indent issues and removes unnecessary condition.

* Modified condition to include case when no_age is not present in the file.
[upstream:cc5606ed9072cb2cea144c1769d601d71bdc8ed1]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit a95e84a into hashicorp:main Dec 5, 2023
2 checks passed
Copy link

github-actions bot commented Jan 5, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About GCS Lifecycle Rules: Adding Unexpected Conditions
1 participant