Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom flattener for diagflowcx agent git integration settings field #16803

Conversation

modular-magician
Copy link
Collaborator

Behavior of this field seems to have changed since GoogleCloudPlatform/magic-modules#9078 was merged.

fixes #16434

Release Note Template for Downstream PRs (will be copied)

dialogflowcx: fixed a permadiff in the `git_integration_settings` field of `google_diagflow_cx_agent`

Derived from GoogleCloudPlatform/magic-modules#9597

…eld (hashicorp#9597)

* Add a custom flattener for the parent field

* Update mmv1/templates/terraform/custom_flatten/dialogflowcx_agent_git_integration_settings_github_settings.go.erb

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

---------

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
[upstream:0c03a04663f6880034c08529349224741bfc3642]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 1fb7ebf into hashicorp:main Dec 14, 2023
4 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccDialogflowCXAgent_update
1 participant