Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource_container_cluster : check node_version and min_master_version on create #16817

Conversation

modular-magician
Copy link
Collaborator

Resource_container_cluster : check node_version and min_master_version on create when calling terraform plan

Fixes #2701

Release Note Template for Downstream PRs (will be copied)

container: added check that node_version and min_master_version are the same on create, when running terraform plan

Derived from GoogleCloudPlatform/magic-modules#9602

…n on create (hashicorp#9602)

* added verification for min_master_version == node_version when creating a cluster when running terraform plan

* Added unit test, refactored function

* Added more extensive unit tests

* Added more test cases to the unit tests
[upstream:c1b0db390ba4ee0fa37c330a46dc8a5d05df48a1]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 424ad4d into hashicorp:main Dec 15, 2023
4 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

terraform plan didn't complain of min_master_version not equal to node_version
1 participant