Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for creating a memcached instance that uses a specific IP address range #17101

Conversation

modular-magician
Copy link
Collaborator

Add support for creating a memcached instance that uses a specific IP address range.
Github issue - fixes #16819

memcache: added `reserved_ip_range_id` field to `google_memcache_instance` resource

Derived from GoogleCloudPlatform/magic-modules#9670

… address range (hashicorp#9670)

* Update Instance.yaml

Add support for creating a memcached instance that uses a specific IP address range.

* Add support for creating a memcached instance that uses a specific IP address range

Add support for creating a memcached instance that uses a specific IP address range.
Github issue - [https://github.com/hashicorp/terraform-provider-google/issues/16819](https://www.google.com/url?q=https://github.com/hashicorp/terraform-provider-google/issues/16819&sa=D&source=buganizer&usg=AOvVaw0idc98DoPRr2rVXo0ACl0V)

* Update Instance.yaml

reservedIpRangeId is used for intial creation only so keeping ignore_read and removing is_set , default_from_api

* Update resource_memcache_instance_test.go

Update test for reserved_ip_range_id field

* Update resource_memcache_instance_test.go

ignore output only fields in update test to fix testAccMemcacheInstance_update

* Update resource_memcache_instance_test.go

Resolved the formatting errors.
[upstream:bd70fcd3fa470cc6c19efc755a78f3cd43c1f592]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 9dc3ce9 into hashicorp:main Jan 25, 2024
4 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add reserved_ip_range field to the google_memcache_instance resource
1 participant