Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Alloydb instance database_flags as default_from_api #17128

Conversation

modular-magician
Copy link
Collaborator

Marking the database_flags field in the alloydb instance resource to be default_from_api
This is needed to reflect the actual database_flags for secondary instance, as the database_flags are copied from primary instance to secondary instance during secondary instance creation.

If the database_flags is not set for secondary instance, it successfully copies the flags during the creation phase.
However, with any further terraform apply command, it believes that the database_flags needs to be removed as the config doesn't have the database_flags field and performs an update operation instead.

Marking default_from_api for the field to true ensures that this doesn't happen

Release Note Template for Downstream PRs (will be copied)

alloydb: fixed an issue where `database_flags` in secondary `google_alloydb_instance` resources would cause a diff, as they are copied from the primary

Derived from GoogleCloudPlatform/magic-modules#9868

)

[upstream:e232aa23b8df870f611996bf1de52563695777d0]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 09b87a4 into hashicorp:main Jan 29, 2024
4 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant