Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add INTERNET_IP_PORT and INTERNET_FQDN_PORT regional network endpoint groups to google cloud terraform provider #17137

Conversation

modular-magician
Copy link
Collaborator

Add INTERNET_IP_PORT and INTERNET_FQDN_PORT options to region_network_endpoint_group and adds region_network_endpoint resource.

This change will be added to both google and google-beta provider versions.

INTERNET_IP_PORT endpoints accepts only IP and port.
INTERNET_FQDN_PORT endpoints accepts only FQDN and port.

Bug: #17000

Release Note Template for Downstream PRs (will be copied)

`google_compute_region_network_endpoint`
added `INTERNET_IP_PORT` and `INTERNET_FQDN_PORT` options for the `google_compute_region_network_endpoint_group` resource. 

Derived from GoogleCloudPlatform/magic-modules#9863

… groups to google cloud terraform provider (hashicorp#9863)

* Add regional INTERNET_IP_PORT and INTERNET_FQDN_PORT NEG to the Google Cloud provider.

This change will be added to both google and google-beta provider versions.

INTERNET_IP_PORT endpoints accepts only IP and port.
INTERNET_FQDN_PORT endpoints accepts only FQDN and port.

* Add regional INTERNET_IP_PORT and INTERNET_FQDN_PORT NEG to the Google Cloud provider.

This change will be added to both google and google-beta provider versions.

INTERNET_IP_PORT endpoints accepts only IP and port.
INTERNET_FQDN_PORT endpoints accepts only FQDN and port.

* Reverse Topic file change

* Fix trailing spaces

* Add region to region_network_endpoint_internet* test examples

* Add basic fine-grained resource test for the  resource

[upstream:55a80b3962e92d86c85608db35c9fae71551ba36]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit d5cdb31 into hashicorp:main Jan 30, 2024
Copy link

github-actions bot commented Mar 2, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant