Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Vertex Search and Conversation Chat Engine #17145

Conversation

modular-magician
Copy link
Collaborator

This PR adds Vertex Search and Conversation Chat Engine

`google_discovery_engine_chat_engine`

This provider has the following field set to default and hard coded to enforce type specific schema validation
solutionType="SOLUTION_TYPE_CHAT"

Derived from GoogleCloudPlatform/magic-modules#9834

…#9834)

* merge change

* add chat_engine

* update chat engine to allow creating new agent only

* fix asyc, update field updatability

* update file name

* sync product.yaml changes

* sync changes

* discard product.yaml change

* update filename case

* add acc test

* fix indentation

* fix indentation

* format

* update API to ga and support location parameter

* Update mmv1/products/discoveryengine/ChatEngine.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Update mmv1/products/discoveryengine/ChatEngine.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* minor changes

* updating fields

* add name output only field, add custom encoder to hardcode solutionType

* update documentation

* update doc

* Update mmv1/products/discoveryengine/ChatEngine.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* update industryVertical to enum

* Update mmv1/products/discoveryengine/ChatEngine.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Update mmv1/products/discoveryengine/ChatEngine.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Update mmv1/products/discoveryengine/ChatEngine.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Update mmv1/templates/terraform/examples/discoveryengine_chat_engine_basic.tf.erb

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Update mmv1/templates/terraform/examples/discoveryengine_chat_engine_basic.tf.erb

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* remove agent creation location field, set default industryVertical

* update test

* Update mmv1/products/discoveryengine/ChatEngine.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Update mmv1/products/discoveryengine/ChatEngine.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Update mmv1/products/discoveryengine/ChatEngine.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Update mmv1/products/discoveryengine/ChatEngine.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Update mmv1/products/discoveryengine/ChatEngine.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Update mmv1/products/discoveryengine/ChatEngine.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* update test

* update example and test

* remove empty line in test

* Apply suggestions from code review

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* add vars for TF examples

* Update mmv1/products/discoveryengine/ChatEngine.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Update mmv1/third_party/terraform/services/discoveryengine/resource_discovery_engine_chat_engine_test.go

remove duplicate test

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Update mmv1/third_party/terraform/services/discoveryengine/resource_discovery_engine_chat_engine_test.go

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* update test names

* format code

* remove redundant test

* Apply suggestions from code review

---------

Co-authored-by: Ray Xu <xrc@google.com>
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

[upstream:a0178b8b4818ac1ab08774fdb81c5ad8bed80b48]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 2a0704d into hashicorp:main Jan 31, 2024
4 checks passed
Copy link

github-actions bot commented Mar 2, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant