Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App check debug token #17242

Conversation

modular-magician
Copy link
Collaborator

Add support for App Check debug tokens. Part of #17095

Note to reviewers: I used a trick to populate a derived field debug_token_id in name's flattening phase. I've tried other hooks such as custom decoders, post_create, etc, but they are injected in awkward places i.e. after the reference of debug_token_id to populate the id, which leads to more overriding code. This one minimizes the amount of custom code and sits just right. I'm open to suggestions if there are better ways. I see an existing similar usage in https://github.com/GoogleCloudPlatform/magic-modules/blob/9c04e74ab0fa1d7198a7a6d15c87143960ac814d/mmv1/templates/terraform/custom_flatten/bigtable_app_profile_routing.erb#L25

Release Note Template for Downstream PRs (will be copied)

`google_firebase_app_check_debug_token`

Derived from GoogleCloudPlatform/magic-modules#9930

* App check debug token

* Make app_id a parameter instead of a virtual field. It seems virtual fields are all forced optional.

* Add update displayName test

* Use api_name and identity to wire up debugTokenId

[upstream:6cfc4dc3f29dcb3e087c0cc468c5ff379867b962]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit f2aef4a into hashicorp:main Feb 9, 2024
4 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant