Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add volume replication support for Google Cloud NetApp Volumes #17348

Commits on Feb 21, 2024

  1. Add volume replication support for Google Cloud NetApp Volumes (hashi…

    …corp#9816)
    
    * Initial replication commit
    
    * Cleanup work
    
    - Renamed a lot of files to make clear which resource the belong to
    - Updated documentation for resource fields
    - Renamed a few resource fields and changed some types
    - Disabled the custom code for now. Needs to be discussed first
    
    * Update example file
    
    * Updated example file
    
    * Major updates
    
    - Reorganisation of block
    - Reorganisation of fields to match API documentation
    - Updated example parameters
    - Added missing API fields
    - Improved descriptions
    -
    
    * For replication deletion, stop replication first
    
    * Add support for deleting destination volume on replication delete
    
    * Make volumes deletable in presence of snapshots.
    
    This change will be PRed for volume resource independently. Adding it here while it is not in main.
    
    * Improving debug error message
    
    * yaml check and format fix
    
    * Add wait for mirror to initialize.
    
    Required to run destroy shortly after create.
    
    * Wait on destroy, not on create
    
    * Make deleting a replication more robust
    
    - doc improvements
    - started to implement stop/resume. More work required.
    - renamed a few files to better reflect what they are good for
    
    * adding support for stop/resume
    
    * yamlformat and lint
    
    * Add force delete to delete volumes with nested snapshots
    
    * resource test first version
    
    * More changes to make tests solid
    
    - Introduced new parameter to wait for mirror_status==MIRRORED
    - more mirror state reconciliation
    
    * Test updates
    
    * few cleanups
    
    * Make virtual field verifies happy
    
    * Minor test improvements
    
    * More fine tuning
    
    - Remove merge conflict in volume.yaml
    - make generated test work
    - make output field work
    - ignore_read for virtual fields
    
    * Resource name change as suggested by @slevenick
    
    * Remove snapshot code block and fix typo
    
    * Detect manual stop/resume actions
    
    * Remove ignore_read for deletion_policy
    
    * - Made destinationVolumeParameters immutable. It still requires ignore_read.
    - removed ignore_read from virtual_fields
    
    * destinationVolumeParameters are only evaluated at create. Make the immutable.
    
    * Name cleanups and comment improvements
    
    * removed comment
    
    Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
    
    * tabs to spaces in resource block
    
    Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
    
    * Updates to address review comments
    
    - make wait_for_mirror also work for stop/resume, additionally to create
    - convert tabs in test resource blocks to spaces
    - fix typos
    
    * Rewording of comments
    
    Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
    
    ---------
    
    Co-authored-by: G-NamanGupta <gnaman@netapp.com>
    Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
    
    [upstream:37fb2ebf10afb245649e86f17bc344bf7b10ef8b]
    
    Signed-off-by: Modular Magician <magic-modules@google.com>
    modular-magician committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    63f3dc9 View commit details
    Browse the repository at this point in the history