Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the namespace_labels field to the GKE Hub Scope resource #17421

Conversation

modular-magician
Copy link
Collaborator

This PR is a follow-up to PR #8882. In addition to labels, the GKE Hub Scope resource has a namespace_labels field.

Release Note Template for Downstream PRs (will be copied)

gkehub2: added `namespace_labels` field to `google_gke_hub_scope` resource

Derived from GoogleCloudPlatform/magic-modules#9972

…icorp#9972)

* initial commit for scope-level namespace labels

* Add validation exceptions for the  field of the GKEHub Scope and Namespace resources to be of type

* Undoing unnecessary changes

* Fixing the type of Scope namespace_labels field

[upstream:3e13564ac5d3ac814949b399e0fd56058445a717]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit e45a120 into hashicorp:main Feb 26, 2024
SarahFrench pushed a commit that referenced this pull request Mar 1, 2024
… (#17421)

* initial commit for scope-level namespace labels

* Add validation exceptions for the  field of the GKEHub Scope and Namespace resources to be of type

* Undoing unnecessary changes

* Fixing the type of Scope namespace_labels field

[upstream:3e13564ac5d3ac814949b399e0fd56058445a717]

Signed-off-by: Modular Magician <magic-modules@google.com>
Copy link

github-actions bot commented Apr 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant