Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the GCF resource to reflect transition from Container Registry to Artifact Registry #17493

Conversation

modular-magician
Copy link
Collaborator

The general transition from Container Registry is outlined in this public doc. The GCF-specific API transition has already completed. The field docker_registry was already marked as optional and computed -- no need for any explicit changes to the defaulting logic here, we only update the docs and comments to reflect the new auto-defaulting.

Release Note Template for Downstream PRs (will be copied)

cloudfunctions: Updated docs for Cloud Function's `docker_registry` field to reflect the change of default from Container Registry to Artifact Registry.

Derived from GoogleCloudPlatform/magic-modules#10058

… to Artifact Registry (hashicorp#10058)

[upstream:d9a016547e57b25a192bfb628f30d78b5a464ad8]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 03376ee into hashicorp:main Mar 5, 2024
4 checks passed
Copy link

github-actions bot commented Apr 5, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2024
@modular-magician modular-magician deleted the downstream-pr-d9a016547e57b25a192bfb628f30d78b5a464ad8 branch November 17, 2024 01:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant