Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add billing project id support to firewall endpoint resource #17630

Conversation

modular-magician
Copy link
Collaborator

Adds support for optional 'description' field and required 'billingProjectId' field to 'google_network_security_firewall_endpoint'

Part of: #15779
Fixes: #17396

Release Note Template for Downstream PRs (will be copied)

networksecurity: added required field `billing_project_id` to `google_network_security_firewall_endpoint` resource. Any configuration without `billing_project_id` specified will cause resource creation fail (beta)

Derived from GoogleCloudPlatform/magic-modules#10122

…rp#10122)

* add billing project support

* removed description field due to API issue

* test updated and fixed for ADC support

* added ADC warning

* removing ADC

[upstream:8f3a9892f4cfeddbaf4dc8457849e30e6ac49b8e]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit b257858 into hashicorp:main Mar 20, 2024
4 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccNetworkSecurityFirewallEndpoints_basic
1 participant