Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release provider-defined functions (#10288) #17694

Merged

Conversation

shuyama1
Copy link
Collaborator

[upstream:c9cf14ddb3cabaec42953e86bdf2be122addb51e]

Release Note Template for Downstream PRs (will be copied)

provider: introduced support for provider-defined functions. This feature is in Terraform v1.8.0+.
provider: added provider-defined function `project_from_id` for retrieving the project id from a resource's self link or id
provider: added provider-defined functions `location_from_id`, `region_from_id`, and `zone_from_id` for retrieving the location/region/zone names from a resource's self link or id
provider: added provider-defined function `name_from_id` for retrieving the short-form name of a resource from its self link or id
provider: added provider-defined function `region_from_zone` for deriving a region from a zone's name

Derived from GoogleCloudPlatform/magic-modules#10288

Copy link

** WARNING **: This repository is generated by https://github.com/GoogleCloudPlatform/magic-modules. Any changes made directly to this repository will likely be overwritten. If you have further questions, please feel free to ping your reviewer or, internal employees, reach out to one of the engineers. Thank you!

@github-actions github-actions bot requested a review from c2thorn March 26, 2024 23:12
@shuyama1 shuyama1 requested review from SarahFrench and removed request for c2thorn March 26, 2024 23:13
@shuyama1 shuyama1 changed the title Release provider-defined functions #10288 Release provider-defined functions (#10288) Mar 26, 2024
Copy link
Collaborator

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to create the changelog file by hand, i.e.: https://github.com/hashicorp/terraform-provider-google/blob/main/.changelog/10295.txt

Copy link
Collaborator

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to create the changelog file by hand, i.e.: https://github.com/hashicorp/terraform-provider-google/blob/main/.changelog/10295.txt

[upstream:c9cf14ddb3cabaec42953e86bdf2be122addb51e]
@shuyama1 shuyama1 force-pushed the downstream-pr-c9cf14ddb3cabaec42953e86bdf2be122addb51e branch from f82ff74 to b8aeaf7 Compare March 26, 2024 23:34
@shuyama1 shuyama1 merged commit 4bbe2ec into main Mar 26, 2024
2 checks passed
@shuyama1 shuyama1 deleted the downstream-pr-c9cf14ddb3cabaec42953e86bdf2be122addb51e branch March 26, 2024 23:38
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants