Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "disabled" support to firewall endpoint association resource #17762

Conversation

modular-magician
Copy link
Collaborator

Adds support for optional 'disabled' field to 'google_network_security_firewall_endpoint_association'

Fixes: #17610
Fixes: #17699

Also fixes to the test 'testAccNetworkSecurityFirewallEndpointAssociation_basic' that started failing due to recent changes to the API, such as the addition of the 'billingProjectId' field to the Firewall Endpoint. (Similar to #17396)

Release Note Template for Downstream PRs (will be copied)

networksecurity: Added 'disabled' field to 'google_network_security_firewall_endpoint_association' resource;
networksecurity: fixed an issue where `google_network_security_firewall_endpoint_association` resources could not be created due to a bad parameter

Derived from GoogleCloudPlatform/magic-modules#10246

…ashicorp#10246)

[upstream:4b61bc2f924d94307cfc6a6892fea3e3e145415f]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 060b708 into hashicorp:main Apr 3, 2024
4 checks passed
Copy link

github-actions bot commented May 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant