Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent permadiff on monitoring_uptime_check_config #18174

Conversation

modular-magician
Copy link
Collaborator

Fixes a permadiff on uptime check config which causes it to be recreated every time.

The labels property in the monitored_resource property should ignore changes to the project_id label if not set by the user. GCP sets the project_id and that causes the resource to exhibit a diff and get recreated every time.

fixes #18038

Release Note Template for Downstream PRs (will be copied)

monitoring: fixed a permadiff with `monitored_resource.labels` property in the `google_monitoring_uptime_check_config` resource

Derived from GoogleCloudPlatform/magic-modules#10694

[upstream:19dd78e2f6cae1217073663eb1d8bb9d584190eb]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 13b292f into hashicorp:main May 17, 2024
4 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monitoring uptime check config recreated each time
1 participant