Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for backup_config in netapp volumes volume resource #18286

Merged
merged 1 commit into from
May 31, 2024
Merged

Adding support for backup_config in netapp volumes volume resource #18286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
124 changes: 124 additions & 0 deletions google/services/netapp/resource_netapp_volume.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,35 @@ func ResourceNetappVolume() *schema.Resource {
Required: true,
Description: `Name of the storage pool to create the volume in. Pool needs enough spare capacity to accomodate the volume.`,
},
"backup_config": {
Type: schema.TypeList,
Optional: true,
Description: `Backup configuration for the volume.`,
MaxItems: 1,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"backup_policies": {
Type: schema.TypeList,
Optional: true,
Description: `Specify a single backup policy ID for scheduled backups. Format: 'projects/{{projectId}}/locations/{{location}}/backupPolicies/{{backupPolicyName}}'`,
Elem: &schema.Schema{
Type: schema.TypeString,
},
},
"backup_vault": {
Type: schema.TypeString,
Optional: true,
Description: `ID of the backup vault to use. A backup vault is reqired to create manual or scheduled backups.
Format: 'projects/{{projectId}}/locations/{{location}}/backupVaults/{{backupVaultName}}'`,
},
"scheduled_backup_enabled": {
Type: schema.TypeBool,
Optional: true,
Description: `When set to true, scheduled backup is enabled on the volume. Omit if no backup_policy is specified.`,
},
},
},
},
"description": {
Type: schema.TypeString,
Optional: true,
Expand Down Expand Up @@ -607,6 +636,12 @@ func resourceNetappVolumeCreate(d *schema.ResourceData, meta interface{}) error
} else if v, ok := d.GetOkExists("snapshot_policy"); !tpgresource.IsEmptyValue(reflect.ValueOf(snapshotPolicyProp)) && (ok || !reflect.DeepEqual(v, snapshotPolicyProp)) {
obj["snapshotPolicy"] = snapshotPolicyProp
}
backupConfigProp, err := expandNetappVolumeBackupConfig(d.Get("backup_config"), d, config)
if err != nil {
return err
} else if v, ok := d.GetOkExists("backup_config"); !tpgresource.IsEmptyValue(reflect.ValueOf(backupConfigProp)) && (ok || !reflect.DeepEqual(v, backupConfigProp)) {
obj["backupConfig"] = backupConfigProp
}
labelsProp, err := expandNetappVolumeEffectiveLabels(d.Get("effective_labels"), d, config)
if err != nil {
return err
Expand Down Expand Up @@ -799,6 +834,9 @@ func resourceNetappVolumeRead(d *schema.ResourceData, meta interface{}) error {
if err := d.Set("snapshot_policy", flattenNetappVolumeSnapshotPolicy(res["snapshotPolicy"], d, config)); err != nil {
return fmt.Errorf("Error reading Volume: %s", err)
}
if err := d.Set("backup_config", flattenNetappVolumeBackupConfig(res["backupConfig"], d, config)); err != nil {
return fmt.Errorf("Error reading Volume: %s", err)
}
if err := d.Set("terraform_labels", flattenNetappVolumeTerraformLabels(res["labels"], d, config)); err != nil {
return fmt.Errorf("Error reading Volume: %s", err)
}
Expand Down Expand Up @@ -879,6 +917,12 @@ func resourceNetappVolumeUpdate(d *schema.ResourceData, meta interface{}) error
} else if v, ok := d.GetOkExists("snapshot_policy"); !tpgresource.IsEmptyValue(reflect.ValueOf(v)) && (ok || !reflect.DeepEqual(v, snapshotPolicyProp)) {
obj["snapshotPolicy"] = snapshotPolicyProp
}
backupConfigProp, err := expandNetappVolumeBackupConfig(d.Get("backup_config"), d, config)
if err != nil {
return err
} else if v, ok := d.GetOkExists("backup_config"); !tpgresource.IsEmptyValue(reflect.ValueOf(v)) && (ok || !reflect.DeepEqual(v, backupConfigProp)) {
obj["backupConfig"] = backupConfigProp
}
labelsProp, err := expandNetappVolumeEffectiveLabels(d.Get("effective_labels"), d, config)
if err != nil {
return err
Expand Down Expand Up @@ -931,6 +975,12 @@ func resourceNetappVolumeUpdate(d *schema.ResourceData, meta interface{}) error
updateMask = append(updateMask, "snapshotPolicy")
}

if d.HasChange("backup_config") {
updateMask = append(updateMask, "backup_config.backup_policies",
"backup_config.backup_vault",
"backup_config.scheduled_backup_enabled")
}

if d.HasChange("effective_labels") {
updateMask = append(updateMask, "labels")
}
Expand Down Expand Up @@ -1581,6 +1631,35 @@ func flattenNetappVolumeSnapshotPolicyMonthlyScheduleDaysOfMonth(v interface{},
return v
}

func flattenNetappVolumeBackupConfig(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
if v == nil {
return nil
}
original := v.(map[string]interface{})
if len(original) == 0 {
return nil
}
transformed := make(map[string]interface{})
transformed["backup_policies"] =
flattenNetappVolumeBackupConfigBackupPolicies(original["backupPolicies"], d, config)
transformed["backup_vault"] =
flattenNetappVolumeBackupConfigBackupVault(original["backupVault"], d, config)
transformed["scheduled_backup_enabled"] =
flattenNetappVolumeBackupConfigScheduledBackupEnabled(original["scheduledBackupEnabled"], d, config)
return []interface{}{transformed}
}
func flattenNetappVolumeBackupConfigBackupPolicies(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
return v
}

func flattenNetappVolumeBackupConfigBackupVault(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
return v
}

func flattenNetappVolumeBackupConfigScheduledBackupEnabled(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
return v
}

func flattenNetappVolumeTerraformLabels(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
if v == nil {
return v
Expand Down Expand Up @@ -2075,6 +2154,51 @@ func expandNetappVolumeSnapshotPolicyMonthlyScheduleDaysOfMonth(v interface{}, d
return v, nil
}

func expandNetappVolumeBackupConfig(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
l := v.([]interface{})
if len(l) == 0 || l[0] == nil {
return nil, nil
}
raw := l[0]
original := raw.(map[string]interface{})
transformed := make(map[string]interface{})

transformedBackupPolicies, err := expandNetappVolumeBackupConfigBackupPolicies(original["backup_policies"], d, config)
if err != nil {
return nil, err
} else if val := reflect.ValueOf(transformedBackupPolicies); val.IsValid() && !tpgresource.IsEmptyValue(val) {
transformed["backupPolicies"] = transformedBackupPolicies
}

transformedBackupVault, err := expandNetappVolumeBackupConfigBackupVault(original["backup_vault"], d, config)
if err != nil {
return nil, err
} else if val := reflect.ValueOf(transformedBackupVault); val.IsValid() && !tpgresource.IsEmptyValue(val) {
transformed["backupVault"] = transformedBackupVault
}

transformedScheduledBackupEnabled, err := expandNetappVolumeBackupConfigScheduledBackupEnabled(original["scheduled_backup_enabled"], d, config)
if err != nil {
return nil, err
} else if val := reflect.ValueOf(transformedScheduledBackupEnabled); val.IsValid() && !tpgresource.IsEmptyValue(val) {
transformed["scheduledBackupEnabled"] = transformedScheduledBackupEnabled
}

return transformed, nil
}

func expandNetappVolumeBackupConfigBackupPolicies(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
return v, nil
}

func expandNetappVolumeBackupConfigBackupVault(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
return v, nil
}

func expandNetappVolumeBackupConfigScheduledBackupEnabled(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
return v, nil
}

func expandNetappVolumeEffectiveLabels(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (map[string]string, error) {
if v == nil {
return map[string]string{}, nil
Expand Down
Loading