Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#11127] Fixes ability to add secret manager secrets IAM bindings with conditions #18294

Merged
merged 1 commit into from
May 31, 2024
Merged

[#11127] Fixes ability to add secret manager secrets IAM bindings with conditions #18294

merged 1 commit into from
May 31, 2024

Conversation

modular-magician
Copy link
Collaborator

  • Fixes ability to add secret manager secrets IAM bindings with conditions.
  • Adds additional tests to verify that IAM bindings with conditions on secret manager secrets are created correctly

Fixes hashicorp/terraform-provider-google/issues/11127

secretmanager: fixed ability to add `google_secret_manager_secret_iam_*` bindings and members with conditions

Derived from GoogleCloudPlatform/magic-modules#10844

@modular-magician
[hashicorp#11127] Fixes ability to add secret manager secrets IAM bin…
505a56a 
…dings with conditions (hashicorp#10844)

Co-authored-by: Luca Prete <lucaprete@google.com>

[upstream:8d5eac137cb5ca51dc764d18d6c7038018b97222]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 8d4b9ad into hashicorp:main May 31, 2024
4 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

google_secret_manager_secret_iam_member fails to save state when adding a conditional iam role
1 participant
@modular-magician