feat(google_container_node_pool): Handle nil mode in secondary boot disk. #18323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isk. (hashicorp#10854) [upstream:042ce9a6893952685b18d666959ab533d0763420] Signed-off-by: Modular Magician <magic-modules@google.com>
11 tasks
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17655
This PR is a follow up to GoogleCloudPlatform/magic-modules#10511, which added Terraform support for secondary boot disks in GKE. I discovered a bug when trying to create a node pool with "mode" not specified. Terraform throws a "panic: interface conversion: interface {} is nil, not map[string]interface {}" during the expandNodeConfig function. I pinpointed the error to the function's type assertion of the mode argument. This PR adds logic to bypass the type assertion when mode is nil.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#10854