Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make google_compute_security_policy's rule_visibility optional + computed and remove default value #18345

Conversation

modular-magician
Copy link
Collaborator

Supersedes GoogleCloudPlatform/magic-modules#8060
Might fix #12743 ?

I find that issue above confusing as it includes 2 issues:

  1. Being unable to create a google_compute_security_policy resource when this is in the config:
adaptive_protection_config {
      layer_7_ddos_defense_config {
          enable = false
      }
}
  1. Issues/expected behaviour when the adaptive_protection_config block is removed:
- adaptive_protection_config {
-      layer_7_ddos_defense_config {
-          enable = false
-      }
-}

This PR addresses issue 1.
I explored issue 2 but decided that it'd be best to address that separately to 1.

Release Note Template for Downstream PRs (will be copied)

compute: fixed issue where users could not create `google_compute_security_policy` resources with `layer_7_ddos_defense_config` explicitly disabled

Derived from GoogleCloudPlatform/magic-modules#10823

…computed and remove default value (hashicorp#10823)

[upstream:a4d43e6167451d6574c964d86cc889dab7c0bde6]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 298ed60 into hashicorp:main Jun 6, 2024
4 checks passed
Copy link

github-actions bot commented Jul 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No-op changes keep appearing in plans for layer_7_ddos_defense_config
1 participant