Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allowlistedCertificates field to TrustConfig #18587

Conversation

modular-magician
Copy link
Collaborator

This CL adds allowlistedCertificates field to TrustConfig resource.
Fixes #18170 and #18385

Tests that I run:
make testacc TEST=./google/services/certificatemanager TESTARGS='-run=TestAccCertificateManagerTrustConfig_certificateManagerTrustConfigAllowlistedCertificatesExample'

make testacc TEST=./google/services/certificatemanager TESTARGS='-run=TestAccCertificateManagerTrustConfig_update'

Manual tests that I performed:

  • Create a resource with one allowlisted
  • Add one more cert to the resource
  • Remove one cert from the resoruce

Release Note Template for Downstream PRs (will be copied)

certificatemanager: added `allowlisted_certificates` to `google_certificate_manager_trust_config`

Derived from GoogleCloudPlatform/magic-modules#10906

Co-authored-by: Hamza Hassan <hamzahassan@google.com>

[upstream:0b9e2683dd1750ec04a869d4ffe54ff7fe0ad292]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 47243ee into hashicorp:main Jun 27, 2024
4 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_certificate_manager_trust_config: Allow listed function is missing in resource block
1 participant